Add symengine #238 #241
Closed
Add symengine #238 #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h the symengine libraries
…and cmake integration
|
@zasexton I cloned your And I don't see the |
|
I've closed this pull request as it was a draft for the eventual incorporation of a symbolic engine. This work is still underway and will be included in a series of pull requests related to #218 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue for adding the optional
symengineandexprtk.hthirdparty libraries tosvFSIplusCurrent situation
Refer to #238 for motivating reason for these additions
Release Notes
This pull request adds an optional cmake argument "SV_USE_SYMENGINE" to optionally fetch and compile the third party library at compilation time.
Documentation
readme documentation has been updated for the
exprtk.hlibrary since the header file was added to theThirdPartyfolder.Testing
Note that this pull request merely makes the
symengineandexprtk.hlibraries available. There is no added functionality withinsvFSIplusbased on these libraries yet. This pull request is to verify and obtain agreement on the code architecture for adding these optional libraries.Code of Conduct & Contributing Guidelines